Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Unknown file name fallback for link text #1330

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

ibolton336
Copy link
Member

  • File URI’s not showing up when they are in a dependency (unable to handle konveyor-jdt scheme)
  • This is a temporary workaround allowing the violation to still be viewed when there is no available file name. Need more info to be able to pull the file name from another place within the dependency.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (58e8ba5) 42.58% compared to head (e61a073) 42.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1330   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files         136      136           
  Lines        4222     4222           
  Branches     1000     1000           
=======================================
  Hits         1798     1798           
  Misses       2412     2412           
  Partials       12       12           
Flag Coverage Δ
client 42.58% <0.00%> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/components/application-form/application-form.tsx 59.60% <0.00%> (ø)
...ntities/components/identity-form/identity-form.tsx 55.87% <ø> (ø)
client/src/app/pages/proxies/proxy-form.tsx 36.29% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 force-pushed the unknown-file-fallback branch from 2bda12a to 9233f37 Compare September 6, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants